Skip to content

Simplify ClassReflectionExtensions #4374

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Sep 27, 2025
Merged

Simplify ClassReflectionExtensions #4374

merged 1 commit into from
Sep 27, 2025

Conversation

staabm
Copy link
Contributor

@staabm staabm commented Sep 27, 2025 •
edited
Loading

identified in #4372

------ ------------------------------------------------------------------------------------------------------------------- 
  Line   src/Reflection/Annotations/AnnotationsMethodsClassReflectionExtension.php                                          
 ------ ------------------------------------------------------------------------------------------------------------------- 
  34     Offset string on array<PHPStan\Reflection\ExtendedMethodReflection> in isset() always exists and is not nullable.  
         🪪  isset.offset                                                                                                   
         at src/Reflection/Annotations/AnnotationsMethodsClassReflectionExtension.php:34                                    
 ------ ------------------------------------------------------------------------------------------------------------------- 

 ------ --------------------------------------------------------------------------------------------------------------------- 
  Line   src/Reflection/Annotations/AnnotationsPropertiesClassReflectionExtension.php                                         
 ------ --------------------------------------------------------------------------------------------------------------------- 
  28     Offset string on array<PHPStan\Reflection\ExtendedPropertyReflection> in isset() always exists and is not nullable.  
         🪪  isset.offset                                                                                                     
         at src/Reflection/Annotations/AnnotationsPropertiesClassReflectionExtension.php:28                                   
 ------ ---------------------------------------------------------------------------------------------------------------------

staabm
staabm commented Sep 27, 2025
View reviewed changes
src/Reflection/Annotations/AnnotationsMethodsClassReflectionExtension.php
if ($method === null) {
return false;
}
$this->methods[$classReflection->getCacheKey()][$methodName] = $method;
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

in case this property is meant to be a cache, I think we could adjust the above IF case, as it effectively means a non-existant method will be checked for over and over again

@staabm
Copy link
Contributor Author

staabm commented Sep 27, 2025

regression test added in 5374f42

@staabm staabm mentioned this pull request Sep 27, 2025
Merged
@ondrejmirtes ondrejmirtes merged commit b94e179 into phpstan:2.1.x Sep 27, 2025
545 of 550 checks passed
@ondrejmirtes
Copy link
Member

Thank you!

@staabm staabm deleted the simpl branch September 27, 2025 15:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@staabm @ondrejmirtes